Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python] Added script to generate Wheel files for MacOS #15024

Merged
merged 1 commit into from
Apr 5, 2022
Merged

[Python] Added script to generate Wheel files for MacOS #15024

merged 1 commit into from
Apr 5, 2022

Conversation

merlimat
Copy link
Contributor

@merlimat merlimat commented Apr 4, 2022

Motivation

Adding script to build Python wheel files for MacOS.

  1. Target MacOS 11.0 as the dev environment, to produce wheels that are going to be compatible with all the subsequent MacOS releases
  2. Compile Python and all the client library dependencies with macOS 11.0 target, and cache all the artifacts
  3. Generate wheels for Python 3.8, 3.9 and 3.10
  4. Generate wheels for native architecture (either x86_64 or arm64) (In future we can try to combine into single universal wheel file).

@merlimat merlimat added this to the 2.11.0 milestone Apr 4, 2022
@merlimat merlimat self-assigned this Apr 4, 2022
@github-actions
Copy link

github-actions bot commented Apr 4, 2022

@merlimat:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@merlimat merlimat added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Apr 4, 2022
@BewareMyPower BewareMyPower added doc-required Your PR changes impact docs and you will update later. and removed doc-not-needed Your PR changes do not impact docs labels Apr 5, 2022
@BewareMyPower
Copy link
Contributor

I think we should add the doc-required label. Because it's better to add the related documents later as the guidance for beginners to build Python wheels. See #9410

BewareMyPower
BewareMyPower reviewed Apr 5, 2022
View reviewed changes
Copy link
Contributor

@BewareMyPower BewareMyPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a workflow that generates wheel files for MacOS so that this script can be verified?

@BewareMyPower
Copy link
Contributor

I think the workflow is not needed at the moment. Maybe we can add it later.

@merlimat merlimat merged commit 0ccadfe into apache:master Apr 5, 2022
@merlimat merlimat deleted the python-mac-wheels branch April 5, 2022 15:37
merlimat added a commit that referenced this pull request Apr 5, 2022
@merlimat
[Python] Added script to generate Wheel files for MacOS (#15024)
aa1fa78
merlimat added a commit that referenced this pull request Apr 5, 2022
@merlimat
[Python] Added script to generate Wheel files for MacOS (#15024)
85aab22
aparajita89 pushed a commit to aparajita89/pulsar that referenced this pull request Apr 6, 2022
@merlimat @aparajita-singh-flipkart
[Python] Added script to generate Wheel files for MacOS (apache#15024)
a00dd13
Lannnnh pushed a commit to Lannnnh/pulsar that referenced this pull request Apr 6, 2022
@merlimat
[Python] Added script to generate Wheel files for MacOS (apache#15024)
461873d
@Anonymitaet
Copy link
Member

@momo-jun a soft reminder: here is a PR w/ doc-required label, could u pls follow up? Thanks

@BewareMyPower BewareMyPower mentioned this pull request Apr 11, 2022
Closed
@momo-jun
Copy link
Contributor

momo-jun commented Apr 11, 2022 •
edited
Loading

Doc status update
The docs required for how to use the .sh script to build python clients targeting macOS and Linux are tracked by #9410. @BewareMyPower will submit a follow-up PR to add docs to this section.

Nicklee007 pushed a commit to Nicklee007/pulsar that referenced this pull request Apr 20, 2022
@merlimat
[Python] Added script to generate Wheel files for MacOS (apache#15024)
c0d09dc
BewareMyPower added a commit to BewareMyPower/pulsar that referenced this pull request Sep 5, 2022
@BewareMyPower
[doc] Fix the release process and regenerate the table of contents
7769e06 
### Motivation

There are some wrong steps in the release process and the "Release
workflow" section is just a list and hard to verify directly.

### Modifications

- Remove the "Move master branch to next version" and "Write release
  notes" sections because they should be done in the last few steps and
  they have already been documented.
- Add the steps to build Docker images when running the vote.
- Skip the release of Helm Chart for patch releases.
- Update the step to publish Python clients for macOS because we won't
  need the VirtualBox after apache#15024.

Regenerate the table of contents via `gh-md-toc` to replace the "Release
workflow" section. Then we can verify it by clicking the link to the
corresponding section.
@BewareMyPower BewareMyPower mentioned this pull request Sep 5, 2022
Merged
4 tasks
BewareMyPower added a commit that referenced this pull request Sep 15, 2022
@BewareMyPower
[doc] Fix the release process (#17470)
a6fe5bb 
### Motivation

There are some wrong steps in the release process and the "Release
workflow" section is just a list and hard to verify directly.

### Modifications

- Remove the "Move master branch to next version" and "Write release
  notes" sections because they should be done in the last few steps and
  they have already been documented.
- Add the steps to build Docker images when running the vote.
- Skip the release of Helm Chart for patch releases.
- Update the step to publish Python clients for macOS because we won't
  need the VirtualBox after #15024.

Regenerate the table of contents via `gh-md-toc` to replace the "Release
workflow" section. Then we can verify it by clicking the link to the
corresponding section.
codertmy pushed a commit to codertmy/pulsar that referenced this pull request Sep 16, 2022
@BewareMyPower
[doc] Fix the release process (apache#17470)
b27d0a7 
### Motivation

There are some wrong steps in the release process and the "Release
workflow" section is just a list and hard to verify directly.

### Modifications

- Remove the "Move master branch to next version" and "Write release
  notes" sections because they should be done in the last few steps and
  they have already been documented.
- Add the steps to build Docker images when running the vote.
- Skip the release of Helm Chart for patch releases.
- Update the step to publish Python clients for macOS because we won't
  need the VirtualBox after apache#15024.

Regenerate the table of contents via `gh-md-toc` to replace the "Release
workflow" section. Then we can verify it by clicking the link to the
corresponding section.
@momo-jun momo-jun removed the doc-required Your PR changes impact docs and you will update later. label Nov 29, 2022
@momo-jun
Copy link
Contributor

Discussed with @BewareMyPower, we recommend users to use the pip install command to install python clients, so it's not necessary to introduce the script in the Pulsar docs.

@momo-jun momo-jun added the doc-not-needed Your PR changes do not impact docs label Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BewareMyPower BewareMyPower BewareMyPower approved these changes

@hangc0276 hangc0276 Awaiting requested review from hangc0276

@codelipenghui codelipenghui Awaiting requested review from codelipenghui

Assignees

@merlimat merlimat

Labels
area/build cherry-picked/branch-2.9 Archived: 2.9 is end of life cherry-picked/branch-2.10 doc-not-needed Your PR changes do not impact docs
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@merlimat @BewareMyPower @Anonymitaet @momo-jun